added String.truncate #4110
Open
added String.truncate #4110
+94
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 70b6f09 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
force-pushed
the
next-minor
branch
from
d2da73b to
20f55ec
Compare
tim-smart
reviewed
Dec 10, 2024
packages/effect/src/String.ts
Outdated
| export const truncate: { | ||
| ( | ||
| str: string, | ||
| lengthOrOptions: |
There was a problem hiding this comment.
I think we should just have an options object instead of a union. Also the member should be readonly.
github-actions
bot
force-pushed
the
next-minor
branch
13 times, most recently
from
fe68352 to
7368257
Compare
github-actions
bot
force-pushed
the
next-minor
branch
3 times, most recently
from
cfe8926 to
1e2ee13
Compare
tim-smart
requested changes
Dec 13, 2024
| return str | ||
| } | ||
|
|
||
| let subString = str.slice(0, options.length) |
There was a problem hiding this comment.
The omission length should be considered too.
github-actions
bot
force-pushed
the
next-minor
branch
2 times, most recently
from
37c2d0e to
ce6e7df
Compare
effect-bot
force-pushed
the
next-minor
branch
28 times, most recently
from
f242776 to
e600b0a
Compare
tim-smart
force-pushed
the
next-minor
branch
from
e600b0a to
8250215
Compare
effect-bot
force-pushed
the
next-minor
branch
from
23d5577 to
c992640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4103