Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: http response stream not interruptible #3922

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

patroza
Copy link
Member

@patroza patroza commented Nov 10, 2024

Preparations:

Steps:

  • send ctrl+c to the server process

Observed:
Process don't exit

Expected:
Process exits

Copy link

changeset-bot bot commented Nov 10, 2024

⚠️ No Changeset found

Latest commit: 6d4067a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@patroza patroza requested a review from tim-smart November 10, 2024 11:38
@patroza
Copy link
Member Author

patroza commented Nov 10, 2024

It looks like one way to do it, is via:

const GetUsers = UserRouter.useScoped((router) =>
  Effect.gen(function*() {
    const ps = yield* PubSub.unbounded<Uint8Array>()
    yield* Effect.addFinalizer(() => ps.shutdown)

but shouldn't the http server terminate the listening to the Stream instead?
the above would never allow streams to be finished, even if you wanted the request to be uninterruptible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Discussion Ongoing
Development

Successfully merging this pull request may close these issues.

1 participant