-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Cause.Annotated #3594
base: next-minor
Are you sure you want to change the base?
add Cause.Annotated #3594
Conversation
🦋 Changeset detectedLatest commit: 9b4e760 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ea1df26
to
ec10d6b
Compare
0ee5b77
to
ab9f25f
Compare
ec10d6b
to
d716e18
Compare
@mikearnaldi This was an idea for a more flexible annotation system for Cause. Maybe something for 4.0? |
We used to have annotations but we removed them in favor of carrying the span in a proxy due to re-fail losing the span |
This goes the route of a re-fail rehydrating the annotations. |
879d15c
to
7714ce1
Compare
Will need to check the details but as far as I understand it's not really possible, spans are linked to a specific error, re-failing with a different error should not hydrate spans |
When you annotate a Die or Fail, it will also add the annotations to the error object using a Proxy (like we do now). If during a re-fail it finds existing annotations, then it will re-add them to the cause. |
f4dc18e
to
ac3c1e7
Compare
5422108
to
bde540b
Compare
8a02eb8
to
d58d2ca
Compare
Co-authored-by: Tim <[email protected]> Co-authored-by: Tim Smart <[email protected]>
… of `Effect` (#3511) Co-authored-by: maksim.khramtsov <[email protected]>
Co-authored-by: maksim.khramtsov <[email protected]>
Co-authored-by: Tim <[email protected]>
Co-authored-by: maksim.khramtsov <[email protected]>
Co-authored-by: maksim.khramtsov <[email protected]>
f242776
to
e600b0a
Compare
e600b0a
to
8250215
Compare
23d5577
to
c992640
Compare
No description provided.