Paul/lifi reporter #194
Merged
Paul/lifi reporter #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullinator
force-pushed
the
paul/lifiReporter
branch
from
6385945 to
027b1b5
Compare
samholmes
approved these changes
Nov 11, 2024
| const response = await fetch(`${url}/v1/integrators/edgeapp`) | ||
| if (!response.ok) { | ||
| const text = await response.text() | ||
| throw new Error(text) |
There was a problem hiding this comment.
The error should include text for lookup
| throw new Error(text) | ||
| } | ||
|
|
||
| const minAmount = Number(process.argv[2] ?? 100) |
There was a problem hiding this comment.
Use a cleaner to avoid NaN numbers
There was a problem hiding this comment.
asStringNumber not available in this repo. Note this is just a cmdline helper tool. It doesn't run in the engine and is run on as needed basis.
Comment on lines
+40
to
+41
| const result = await response.json() | ||
| const integrators = asIntegrators(result) |
There was a problem hiding this comment.
I wonder why we don't use asJSON more often?
| const integrators = asIntegrators(result) | ||
| let balUsd = 0 | ||
| const tokenAddresses: { [chainId: string]: string[] } = {} | ||
| console.log(JSON.stringify(integrators, null, 2)) |
There was a problem hiding this comment.
Is this console log for debugging?
There was a problem hiding this comment.
yes, but this whole script is just a helper tool
| console.log(JSON.stringify(integrators, null, 2)) | ||
| integrators.feeBalances.forEach(fb => { | ||
| fb.tokenBalances.forEach(tb => { | ||
| const amount = Number(tb.amountUsd) |
There was a problem hiding this comment.
Hmm, why not use an asStringNumber?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none