Use getAddresses in Request scene #5363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
approved these changes
Nov 18, 2024
Comment on lines
+147
to
+154
| const addressTypeLabelMap: StringMap = { | ||
| segwitAddress: lstrings.request_qr_your_segwit_address, | ||
| legacyAddress: lstrings.request_qr_your_legacy_address, | ||
|
|
||
| // Handle segwitAddress | ||
| if (receiveAddress.segwitAddress != null) { | ||
| addresses.push({ | ||
| addressString: receiveAddress.segwitAddress, | ||
| label: lstrings.request_qr_your_segwit_address | ||
| }) | ||
| // Zcash | ||
| saplingAddress: lstrings.request_qr_your_sapling_address, | ||
| transparentAddress: lstrings.request_qr_your_transparent_address, | ||
| unifiedAddress: lstrings.request_qr_your_unified_address |
There was a problem hiding this comment.
👍 This table is really nice.
peachbits
force-pushed
the
matthew/all-addresses
branch
from
7f3d1fe to
9532444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/edge-core-js#626
EdgeApp/edge-currency-accountbased#855
Requirements
If you have made any visual changes to the GUI. Make sure you have: