Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay styling for "Wallet Paused" #4539

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Overlay styling for "Wallet Paused" #4539

merged 1 commit into from
Oct 20, 2023

Conversation

Jon-edge
Copy link
Collaborator

@Jon-edge Jon-edge commented Oct 19, 2023

Simulator Screenshot - iPhone 14 - 2023-10-19 at 16 23 44

Simulator Screenshot - iPhone 14 - 2023-10-19 at 16 23 59

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, but I have some ideas about how to simplify the CSS. If you don't want to do this, then we could merge as-is.

src/components/themed/WalletListCurrencyRow.tsx Outdated Show resolved Hide resolved
src/components/themed/WalletListCurrencyRow.tsx Outdated Show resolved Hide resolved
src/components/themed/WalletListCurrencyRow.tsx Outdated Show resolved Hide resolved
@Jon-edge Jon-edge force-pushed the jon/pause-wallet-ui branch from 2090738 to 15a1d9c Compare October 20, 2023 20:48
@Jon-edge Jon-edge enabled auto-merge October 20, 2023 20:49
@Jon-edge Jon-edge force-pushed the jon/pause-wallet-ui branch 2 times, most recently from 09afc26 to 463c19c Compare October 20, 2023 22:19
Comment on lines 76 to 78
overlayLabelContainer: {
...StyleSheet.absoluteFillObject
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be unused now.

@Jon-edge Jon-edge force-pushed the jon/pause-wallet-ui branch from 463c19c to 6ad6124 Compare October 20, 2023 23:10
@Jon-edge Jon-edge merged commit e6d9aad into develop Oct 20, 2023
2 checks passed
@Jon-edge Jon-edge deleted the jon/pause-wallet-ui branch October 20, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants