Remove price-change push event subscription for deprecated currencies #4523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullinator
requested changes
Oct 19, 2023
src/actions/NotificationActions.ts
Outdated
| const { trigger } = event | ||
| if (trigger.type === 'price-change') { | ||
| const currencyInfo = activeCurrencyInfos.find(currencyInfo => currencyInfo.pluginId === trigger.pluginId) | ||
| if (currencyInfo == null || SPECIAL_CURRENCY_INFO[currencyInfo.pluginId].keysOnlyMode) { |
There was a problem hiding this comment.
Dont remove assets that aren't active as they may be in another account
paullinator
approved these changes
Oct 23, 2023
samholmes
force-pushed
the
sam/bsv-notifications
branch
from
21e3e1e to
5f8b87c
Compare
samholmes
force-pushed
the
sam/bsv-notifications
branch
from
5f8b87c to
8b0cb3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: