Patch return URL status

EdgeApp · Dec 13, 2024 · 5958580 · 5958580
1 parent ee30006
commit 5958580
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/plugins/gui/providers/banxaProvider.ts b/src/plugins/gui/providers/banxaProvider.ts
@@ -601,8 +601,12 @@ export const banxaProvider: FiatProviderFactory = {
 
                   const orderResponse = await banxaFetch({ method: 'GET', url, hmacUser, path: `api/orders/${banxaQuote.data.order.id}`, apiKey })
                   const order = asBanxaOrderResponse(orderResponse)
+                  // Banxa will incorrectly add their query string parameters
+                  // to the url with a simple concatenation of '?orderId=...',
+                  // and this will break our query string.
+                  const status = link.query.status?.replace('?', '')
 
-                  switch (link.query.status) {
+                  switch (status) {
                     case 'success': {
                       await showUi.trackConversion('Buy_Success', {
                         conversionValues: {

diff --git a/src/plugins/gui/providers/simplexProvider.ts b/src/plugins/gui/providers/simplexProvider.ts
@@ -366,8 +366,12 @@ export const simplexProvider: FiatProviderFactory = {
                 if (link.direction !== 'buy') return
 
                 const orderId = link.query.orderId ?? 'unknown'
+                // Simplex _may_ incorrectly add their query string parameters
+                // to the url with a simple concatenation of '?orderId=...'
+                // (like Banxa), and this will break our query string.
+                const status = link.query.status?.replace('?', '')
 
-                switch (link.query.status) {
+                switch (status) {
                   case 'success': {
                     await showUi.trackConversion('Buy_Success', {
                       conversionValues: {