Skip to content

Commit

Permalink
Merge pull request #4532 from EdgeApp/paul/paybisSell
Browse files Browse the repository at this point in the history
Paul/paybis sell
  • Loading branch information
paullinator authored Oct 21, 2023
2 parents e6d9aad + d191cd9 commit 1e32b41
Show file tree
Hide file tree
Showing 10 changed files with 420 additions and 161 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased

- added: "Paused Wallet" visual indicator on wallet list
- added: Paybis sell to debit card
- changed: Change FlipInput styling to make the edit functionality more obvious
- changed: Move asset-specific settings into their own settings page

Expand Down
15 changes: 0 additions & 15 deletions scripts/html/paybis.html

This file was deleted.

15 changes: 0 additions & 15 deletions scripts/html/paybisSandbox.html

This file was deleted.

14 changes: 14 additions & 0 deletions src/__tests__/__snapshots__/GuiPlugins.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,20 @@ Settlement: Instant",

exports[`Production plugin data Sell plugins match snapshot on iOS + US 1`] = `
[
{
"cryptoCodes": [],
"deepPath": "",
"deepQuery": {},
"description": "Fee: 2.5%
Settlement: 5 min - 24 hours",
"paymentType": "credit",
"paymentTypeLogoKey": "bank",
"paymentTypes": [
"credit",
],
"pluginId": "debit",
"title": "Bank Transfer via Debit Card",
},
{
"cryptoCodes": [],
"deepPath": "",
Expand Down
8 changes: 8 additions & 0 deletions src/constants/plugins/GuiPlugins.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,14 @@ export const guiPlugins: { [pluginId: string]: GuiPlugin } = {
nativePlugin: amountQuoteFiatPlugin,
displayName: 'Credit Card'
},
debit: {
pluginId: 'amountquote',
storeId: '',
baseUri: '',
lockUriPath: true,
nativePlugin: amountQuoteFiatPlugin,
displayName: 'Debit Card'
},
directtobank: {
pluginId: 'amountquote',
storeId: '',
Expand Down
11 changes: 11 additions & 0 deletions src/constants/plugins/sellPluginList.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,17 @@
"cryptoCodes": [],
"paymentTypeLogoKey": "bank"
},
{
"id": "debit",
"pluginId": "debit",
"paymentType": "credit",
"paymentTypes": ["credit"],
"title": "Bank Transfer via Debit Card",
"description": "Fee: 2.5%\nSettlement: 5 min - 24 hours",
"forCountries": ["US"],
"cryptoCodes": [],
"paymentTypeLogoKey": "bank"
},
{
"id": "fasterpayments",
"pluginId": "fasterpayments",
Expand Down
5 changes: 1 addition & 4 deletions src/plugins/gui/providers/banxaProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,11 @@ import {
FiatProviderGetQuoteParams,
FiatProviderQuote
} from '../fiatProviderTypes'
import { NOT_SUCCESS_TOAST_HIDE_MS, RETURN_URL_CANCEL, RETURN_URL_FAIL, RETURN_URL_SUCCESS } from './common'
const providerId = 'banxa'
const storeId = 'banxa'
const partnerIcon = 'banxa.png'
const pluginDisplayName = 'Banxa'
const RETURN_URL_SUCCESS = 'https://edge.app/'
const RETURN_URL_FAIL = 'https://edge.app/fail/'
const RETURN_URL_CANCEL = 'https://edge.app/cancel/'
const NOT_SUCCESS_TOAST_HIDE_MS = 5000

const TESTNET_ADDRESS = 'bc1qv752cnr3rcht3yyfq2nn6nv7zwczqjmcm80y6w'
let testnet = false
Expand Down
6 changes: 6 additions & 0 deletions src/plugins/gui/providers/common.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
export const RETURN_URL_SUCCESS = 'https://edge.app/redirect/success/'
export const RETURN_URL_FAIL = 'https://edge.app/redirect/fail/'
export const RETURN_URL_CANCEL = 'https://edge.app/redirect/cancel/'
export const RETURN_URL_PAYMENT = 'https://edge.app/redirect/payment/'

export const NOT_SUCCESS_TOAST_HIDE_MS = 5000
Loading

0 comments on commit 1e32b41

Please sign in to comment.