Jon/desktop modal x 2 #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
force-pushed
the
jon/desktop-modal-x
branch
from
42e12ac to
9f26781
Compare
swansontec
approved these changes
Feb 28, 2025
Comment on lines
17
to
19
| export function useLoginUi(): { hasProvider: boolean; isDesktop: boolean } { | ||
| return React.useContext(loginUiContext) | ||
| } |
There was a problem hiding this comment.
This useLoginUi wrapper isn't used anywhere, so let's just drop it. It doesn't improve usability much.
Minor difference: use `context` from GUI to determine `isDesktop` instead of the native dependency
Jon-edge
force-pushed
the
jon/desktop-modal-x
branch
from
9f26781 to
0ff719f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none