Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Seen Tx Checkpoint API #420

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Integrate Seen Tx Checkpoint API #420

merged 3 commits into from
Jan 15, 2025

Conversation

samholmes
Copy link
Contributor

@samholmes samholmes commented Jan 2, 2025 •
edited
Loading

  • Change Blockbook connection for test
  • Upgrade edge-core-js@^2.22.1
  • Remove transactionChanged
  • Integrate new Seen Tx Checkpoint API

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

none

@samholmes samholmes force-pushed the sam/seenTxCheckpoint branch from e76e5f2 to e089ee1 Compare January 3, 2025 21:28
swansontec
swansontec requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small changes needed here.

src/common/utxobased/engine/UtxoEngine.ts Outdated Show resolved Hide resolved
src/common/utxobased/db/Models/TransactionData.ts Outdated Show resolved Hide resolved
package.json Outdated
@@ -87,7 +87,7 @@
"base-x": "^4.0.0",
"chai": "^4.2.0",
"chai-as-promised": "^7.1.1",
"edge-core-js": "^2.22.1",
"edge-core-js": "../edge-core-js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely fix this before merging.

src/common/utxobased/engine/UtxoEngine.ts Outdated Show resolved Hide resolved
src/common/utxobased/engine/UtxoEngineProcessor.ts Outdated Show resolved Hide resolved
test/common/utxobased/engine/engine.spec.ts Outdated Show resolved Hide resolved
@samholmes samholmes force-pushed the sam/seenTxCheckpoint branch from e089ee1 to 43d7b6a Compare January 14, 2025 22:23
@samholmes samholmes force-pushed the sam/seenTxCheckpoint branch 2 times, most recently from c11aa5b to 05cc5f5 Compare January 15, 2025 23:24
@samholmes samholmes force-pushed the sam/seenTxCheckpoint branch from 05cc5f5 to 5267e07 Compare January 15, 2025 23:25
@samholmes samholmes marked this pull request as ready for review January 15, 2025 23:25
@samholmes samholmes enabled auto-merge January 15, 2025 23:25
@samholmes samholmes merged commit 29b441f into master Jan 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swansontec swansontec swansontec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samholmes @swansontec