Block Reward Transaction Support (Coinbase Txs) #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The errors through were crashing the `taskGeneratorFn` routine, halting the wallet entirely. Instead, the errors should be delegated to the pickNextTask routine to be handled or not. If handled, then continue the routine with result, if not, then assume a end result, and continue.
samholmes
force-pushed
the
sam/blockrewards
branch
from
c22ee01 to
b166a70
Compare
swansontec
approved these changes
Nov 5, 2024
| version "0.3.16" | ||
| resolved "https://registry.yarnpkg.com/cleaners/-/cleaners-0.3.16.tgz#d3a7ab936cb78b0d6ac19ba87b2d28ec41f30502" | ||
| integrity sha512-Ecu8Fwv3wT7GV44K4Zas2CQJI11ZV/yPwoh8Gg9BSV6rAmhNsqFeWceA1RII1czbarFSG3XClUePrpI806OvRw== | ||
|
|
||
| cleaners@^0.3.17: |
There was a problem hiding this comment.
Please run the yarn-deduplicate tool in this repo. We don't need multiple copies of the cleaner library.
Comment on lines
+98
to
+100
| asEither( | ||
| // Address input: | ||
| asObject({ |
There was a problem hiding this comment.
Optional: This cleaner is getting pretty deep. It might be easier to read if we define asAddressVin and asCoinbaseVin types on the outside, and then do asEither(asAddressVin, asCoinbaseVin) in here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none