Currency info cleanup #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
approved these changes
Apr 22, 2024
| @@ -6,10 +6,12 @@ import { maximumFeeRateCalculator } from '../../plugin/util/maximumFeeRateCalcul | |||
| import { memoInfo } from './commonInfo' | |||
|
|
|||
| export const currencyInfo: EdgeCurrencyInfo = { | |||
| pluginId: 'litecoin', | |||
| walletType: 'wallet:litecoin', | |||
| canReplaceByFee: false, | |||
There was a problem hiding this comment.
I feel like canReplaceByFee field is in a different "group" or category of fields for the EdgeCurrencyInfo. Perhaps it would make sense to put a comment above canReplaceByFee and potentially other fields like it and separate it from the required fields like pluginId and currencyCode.
There was a problem hiding this comment.
Seeing the following commits after this comment made me realize the change request is too much rebasing effort to be worth it. I'll leave the idea here as optional though.
This matches how edge-currency-accountbased does it, and clears the way for deprecating `defaultSettings`
Also move more things to the deprecated section, including legacy memo fields.
swansontec
force-pushed
the
william/currency-info-cleanup
branch
from
eaf69cc to
0420d18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
It turns out we already had fee templates in here, so I just reorganized things to match edge-currency-accountbased a bit more.