Add NOWNodes to EngineInfo #396
Conversation
samholmes
force-pushed
the
sam/http-blockbook
branch
from
113c130 to
eb82f60
Compare
| export interface ServerConfig { | ||
| type: 'blockbook-nownode' | ||
| uris: string[] | ||
| } |
There was a problem hiding this comment.
This structure seems weird. Why not put fallbackNownodeServers?: string[] straight into the engine info / init info?
I mean, it's always possible to invent your own custom object type using arrays, like type FakeObject<T> = Array<{ key: string, value: T}>, but this sort of thing is rarely a good idea. Just use normal objects.
The ServerConfig type seems to be implementing this anti-pattern, with type as the key and uris as the value. Rather than using string enums and arrays, it would be simpler to just use named properties right on the relevant objects.
There was a problem hiding this comment.
Because: It's easier to enumerate nominal types then fields in typescript.
There was a problem hiding this comment.
Ok, we discussed this design some more, and it makes sense if the servers need extra data, such as contract addresses or such. In that case, it might be { type: 'foo', servers: [], queryParams: '' }, and so we want the flexibility of the array approach. This will impact the way the info server assembles the core rollup payload, so we might need a follow-up PR over there.
samholmes
force-pushed
the
sam/http-blockbook
branch
2 times, most recently
from
fb01b55 to
962f7df
Compare
samholmes
changed the title
samholmes
force-pushed
the
sam/http-blockbook
branch
2 times, most recently
from
0990871 to
5b2f4d4
Compare
The convention is such that if a file's main purpose is to define a interface/type by a class or factory function, then the file name should match the name of that interface. So, we remove "make" from file names, and we make some changes to interface type names to match the file name.
This is less likely to be confused with an on-chain address.
This infra is similar to accountbased currencies in that we maintain a list of server configs that can match with a specific key from initOptions. The only difference with this implementation is that there is no info-server support for this integration yet. These servers will only be used as fallback servers if WebSocket broadcasts fail.
samholmes
force-pushed
the
sam/http-blockbook
branch
from
5b2f4d4 to
fe9e6aa
Compare
This infra is similar to accountbased currencies in that we maintain
a list of server configs that can match with a specific key from
initOptions.
The only difference with this implementation is that there is no
info-server support for this integration yet.
These servers will only be used as fallback servers if WebSocket
broadcasts fail.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none