Check fee amount compared to inputs for subtractFee style transactions

It was the only utxo picker without a path to check for insufficient funds
EdgeApp · Jan 24, 2024 · f848dc4 · f848dc4
1 parent d5ee729
commit f848dc4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- changed: Add insufficient funds check `subtractFee` style transactions
+
 ## 2.5.2 (2024-01-23)
 
 - removed: Disable `accelerate` for bip32 (Airbitz) wallets

diff --git a/src/common/utxobased/keymanager/utxopicker/subtractFee.ts b/src/common/utxobased/keymanager/utxopicker/subtractFee.ts
@@ -13,5 +13,9 @@ export function subtractFee(args: UtxoPickerArgs): UtxoPickerResult {
   const fee = Math.ceil(feeRate * utils.transactionBytes(utxos, outputs))
   targets[0].value -= fee
   outputs[0].value -= fee
+
+  const targetValue = utils.sumOrNaN(targets)
+  if (fee > targetValue) return { inputs: utxos, fee, changeUsed: false }
+
   return { inputs: utxos, outputs, fee, changeUsed: false }
 }