Add networkFees to EdgeTransaction type #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
requested changes
Nov 21, 2024
samholmes
force-pushed
the
sam/networkFees
branch
from
dd8991e to
29839d7
Compare
swansontec
approved these changes
Nov 25, 2024
Comment on lines
+39
to
+42
| if (quote.networkFee != null && quote.networkFee.tokenId == null) { | ||
| quote.networkFee.tokenId = quote.request.fromTokenId | ||
| } |
There was a problem hiding this comment.
I would have put this code directly into fetchSwapQuotes, rather than creating a separate method, since that's less cognitive load. Optional (but recommended) change, since this way works too.
This improves IDE integration.
The parentNetworkFee is not defined if the transaction is of the native currency. This was an issue when reading txs from disk (getTransations/streaming).
samholmes
force-pushed
the
sam/networkFees
branch
from
29839d7 to
80bd7cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none