Fix an error while changing the PIN #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to have two variables with the same name, `children`, but existing in separate scopes. Unfortunately, the minifier mis-compiled this code, referring to the inner variable instead of the outer variable. To fix this, we just give the outer variable a different name, forcing the minifier to refer to the correct one.
peachbits
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have two variables with the same name,
children, but existing in separate scopes. Unfortunately, the minifier mis-compiled this code, referring to the inner variable instead of the outer variable. To fix this, we just give the outer variable a different name, forcing the minifier to refer to the correct one.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none