Log unknown swap errors #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
force-pushed
the
sam/log-unknown-swap-errors
branch
from
625859d to
898fa54
Compare
swansontec
approved these changes
Oct 24, 2024
src/core/swap/swap-api.ts
Outdated
Comment on lines
253
to
256
| function isUnknownSwapError(error: unknown): boolean { | ||
| return ( | ||
| asMaybeInsufficientFundsError(error) == null && | ||
| asMaybePendingFundsError(error) == null && | ||
| asMaybeSwapAboveLimitError(error) == null && | ||
| asMaybeSwapBelowLimitError(error) == null && | ||
| asMaybeSwapPermissionError(error) == null && | ||
| asMaybeSwapCurrencyError(error) == null | ||
| ) | ||
| } |
There was a problem hiding this comment.
Instead of building this whole new function, could we use rankError(error) <= 1?
There was a problem hiding this comment.
Oh, hmm.. The functions are semantically different and their is motivation for them to diverge in the future as we filter out noisy errors. Shall we opt to keep them distinct for this reason?
There was a problem hiding this comment.
If we give the error a score, then we know what it is, and by definition the error cannot be "unknown". Let's leverage this fact, but still keep the functions distinct:
function isUnknownSwapError(error: unknown): boolean {
isKnownError = rankError(error) > 1
return !isKnownError
}
src/core/swap/swap-api.ts
Outdated
| // Stringify to include "null" | ||
| toToken: String(request.toTokenId), | ||
| toWalletType: request.toWallet.type, | ||
| // toWalletType: request.fromWallet.type, |
samholmes
force-pushed
the
sam/log-unknown-swap-errors
branch
from
898fa54 to
0fefaa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none