Add worstAmount to EdgeSwapQuote
#616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullinator
requested changes
Sep 6, 2024
src/types/types.ts
Outdated
| @@ -791,7 +791,6 @@ export interface EdgeGetTransactionsOptions { | |||
| startDate?: Date | |||
| endDate?: Date | |||
| searchString?: string | |||
| spamThreshold?: string | |||
There was a problem hiding this comment.
Made changes on an older revision and pasted instead of rebasing or using stashes apparently, will reinstate
src/types/types.ts
Outdated
|
|
||
| /** Worse case amount - the highest cost for a 'from' quote, and the lowest | ||
| * receive amount for a 'to' quote */ | ||
| readonly worstAmount?: string |
There was a problem hiding this comment.
Change to minAmount. Regardless of the quote being from or to, this will always be the minimum RECEIVE amount. I'd be ok renaming to minReceiveAmount
Jon-edge
force-pushed
the
jon/worst-swap-amount
branch
from
76fe9d2 to
a05b4a6
Compare
paullinator
approved these changes
Sep 9, 2024
2 tasks
Jon-edge
force-pushed
the
jon/worst-swap-amount
branch
from
a05b4a6 to
62c6e61
Compare
Jon-edge
force-pushed
the
jon/worst-swap-amount
branch
from
62c6e61 to
44624fd
Compare
swansontec
requested changes
Sep 11, 2024
src/types/types.ts
Outdated
Comment on lines
821
to
823
| /** Filter incoming transactions with a `nativeAmount` below this */ | ||
| spamThreshold?: string | ||
|
|
There was a problem hiding this comment.
This is still missing. Please put it back when you rebase.
Jon-edge
force-pushed
the
jon/worst-swap-amount
branch
from
44624fd to
afb455a
Compare
Jon-edge
force-pushed
the
jon/worst-swap-amount
branch
from
afb455a to
677266f
Compare
swansontec
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none