Add makeMemoryWallet method #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 19, 2024
swansontec
requested changes
Jun 24, 2024
peachbits
force-pushed
the
matthew/makeRamWallet
branch
from
12c5805 to
8ccc772
Compare
swansontec
approved these changes
Jun 25, 2024
src/types/types.ts
Outdated
| @@ -893,6 +893,7 @@ export interface EdgeCurrencyEngineCallbacks { | |||
|
|
|||
| export interface EdgeCurrencyEngineOptions { | |||
| callbacks: EdgeCurrencyEngineCallbacks | |||
| lightMode?: boolean // Flag indicating that the engine only needs to sync the balance and be able to spend | |||
There was a problem hiding this comment.
Can we do it JavaDoc style:
/** True if we only need a balance and the ability to spend it. */
lightMode?: boolean
peachbits
force-pushed
the
matthew/makeRamWallet
branch
2 times, most recently
from
415ac8b to
f612433
Compare
Intended to be used briefly and without any local state saved. It returns once the underlying engine is fully synced.
The memory wallet is temporary that just needs to get balances and spend. An engine recognizing lightMode can reduce unnecessary operations like transaction history
peachbits
force-pushed
the
matthew/makeRamWallet
branch
from
f612433 to
2768186
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none