New enableRbf field on EdgeSpendInfo #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
requested changes
Jun 7, 2024
src/types/types.ts
Outdated
| @@ -670,6 +670,7 @@ export interface EdgeSpendInfo { | |||
| /** Enables/disables RBF for currencies where RBF is opt-in or optional. */ | |||
| enableRbf?: boolean | |||
| pendingTxs?: EdgeTransaction[] | |||
| /** @deprecated Use enableRbf instead */ | |||
There was a problem hiding this comment.
The enableRbf flag isn't right alternative. This comment should say "Use EdgeCurrencyWallet.accelerate instead"
samholmes
force-pushed
the
sam/rbf-spend-info
branch
from
b90ae66 to
5374807
Compare
swansontec
approved these changes
Jun 10, 2024
samholmes
force-pushed
the
sam/rbf-spend-info
branch
from
3dcac6f to
0fe2038
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none