Add 'failed' variant to EdgeTransaction confirmations API

EdgeApp · Mar 25, 2024 · f015d51 · f015d51
1 parent b6012de
commit f015d51
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- added: New `'failed'` value to confirmations field on `EdgeTransactions`
+
 ## 2.3.0 (2024-03-23)
 
 - added: `EdgeCorePluginOptions.infoPayload`, containing arbitrary JSON provided by the info server.

diff --git a/src/core/currency/wallet/currency-wallet-callbacks.ts b/src/core/currency/wallet/currency-wallet-callbacks.ts
@@ -417,7 +417,11 @@ export function watchCurrencyWallet(input: CurrencyWalletInput): void {
 const shouldCoreDetermineConfirmations = (
   confirmations: EdgeConfirmationState | undefined
 ): boolean => {
-  return confirmations !== 'confirmed' && confirmations !== 'dropped'
+  return (
+    confirmations !== 'confirmed' &&
+    confirmations !== 'dropped' &&
+    confirmations !== 'failed'
+  )
 }
 
 export const determineConfirmations = (

diff --git a/src/types/types.ts b/src/types/types.ts
@@ -546,6 +546,9 @@ export type EdgeConfirmationState =
   | 'confirmed'
   // Dropped from the network without confirmations:
   | 'dropped'
+  // Confirmed, but failed on-chain execution (exceeded gas limit,
+  // smart-contract failure, etc):
+  | 'failed'
   // We don't know the chain height yet:
   | 'syncing'
   // No confirmations yet: