Toast are not showing 2nd time in iOS12.1

[aman2604]

No description provided.

[aman2604]

I am using 2.5.2 version which doesn't contain this change but once I updated it to 2.7.2 then toast is not showing 2nd time for iOS 12. So removing this change.

[aman2604]

Please review - @EddyVerbruggen

[EddyVerbruggen]

@aman2604 If you're happy with the change, and it still works on (let's say) iOS 11, then I'd be happy to merge it.

[aman2604]

@EddyVerbruggen - 83% of all devices introduced in the last 4 years are using iOS 12 and I don't have iOS 11 device. Please refer - https://developer.apple.com/support/app-store/

[EddyVerbruggen]

@aman2604 Sure, but if this would break iOS 11 support (I'm not saying it does!) all hell will break loose; this plugin has ~5k daily downloads so there will be a lot of app users. If for 17% the app crashes: 😱

[aman2604]

@EddyVerbruggen - I tried it on iOS11 and it is working there as well.

[EddyVerbruggen]

About to merge, but it doesn't feel right that we're reversing #112 here. I think change will break cases that #112 fixed. @yjajkiew if you're still using this plugin: do you have thoughts on reverting your PR, and/or do you recall what the problem was that #112 solved?

[aman2604]

@EddyVerbruggen - Could you please merge this PR?

[yjajkiew]

Reverting #112 will have consequences on application using multiple layers : in my case if it's revert it can cause toast to not work at all on iOS when using InAppBrowser, that's why I made #112 in the first place.
As to why it toast does not show 2nd time on iOS 12.1 I should make some tests and try this PR, hopefully tomorrow, to understand the problem.

[EddyVerbruggen]

@yjajkiew Thanks so much for chiming in!

[yjajkiew]

Hello, sorry for the delay but I finally found the time to try to reproduce this error but I can't.
By using the plugin without this PR (so without reverting #112) toasts messages on iOS 12.1 can show up multiple times !

Steps to reproduce :

1. launch an app on simulator (iPhone 8 Plus 12.1)
2. launch the following commands from index.js :

• window.plugins.toast.show('test 1', 2000, 'bottom');
• window.plugins.toast.show('test 2', 2000, 'bottom');
• window.plugins.toast.show('test 3', 2000, 'bottom');
• window.plugins.toast.show('test 1', 2000, 'bottom');

3. the results are : all toast messages showing up

Can someone else test this to confirm ? Or can someone else confirm @aman2604 's problem ?

[aman2604]

@yjajkiew - I tried this on simulator and issue is coming for iOS 11 simulator also.

[yjajkiew]

Can you give us some contexts about your application that may be causing this issue ? I can not reproduce.

[aman2604]

@yjajkiew - We are showing the Toast message on button click and then opening a alert dialog. Once alert dialog is closed, we are opening the second toast. Also, we are doing it in the iframe.

[aman2604]

@yjajkiew - A gentle reminder for this.