Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Update README.md #3801

Closed
wants to merge 0 commits into from
Closed

Update README.md #3801

wants to merge 0 commits into from

Conversation

LuciaSheel
Copy link
Contributor

add name

Related issue

add name

What changes does this PR do?

Adds my name and GitHub profile link to the Readme file

Screenshots (If any)

Questions

Copy link

This repository is for practice only and therefore it will not count towards hacktoberfest.

@LuciaSheel LuciaSheel closed this Sep 23, 2024
@LuciaSheel LuciaSheel reopened this Sep 23, 2024
Copy link
Member

@AvidCoder101 AvidCoder101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your name in alphabetical order - before line 1613

@LuciaSheel
Copy link
Contributor Author

Thank you for your feedback @AvidCoder101 ! Can you please take another look at the pull request you commented on? I am certain that it is correct no matter if you are using a word by word or letter by letter method of alphabetization. Thanks : )

Copy link
Member

@AvidCoder101 AvidCoder101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuciaSheel hi, sorry if there is any misunderstanding, I think that it's meant to go on line 1613 because your first name ends with A and the name before yours (Luciano) continues with the letter N, which using letter by letter would mean it goes after yours alphabetically? Sorry if that's confusing

@LuciaSheel LuciaSheel closed this Sep 25, 2024
@LuciaSheel
Copy link
Contributor Author

@AvidCoder101
Hunh. Sorry, I did an oopsies. Gonna try this again. Learning.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants