[ODS-6175] Migrate GenerateSecurityGraphs to .NET 8 #933
Conversation
| if (options.User == null || options.Password == null) | ||
| { | ||
| connectionString = string.Format( | ||
| "Server={0};Database={1};Trusted_Connection=True", | ||
|
|
||
| "Server={0};Database={1};Trusted_Connection=True;Encrypt=False", |
There was a problem hiding this comment.
https://techdocs.ed-fi.org/display/ODSAPIS3V71/Security+Visualization+Tool this page helped me see how this tool is used by the public.
I don't like having a hard-coded connection string, and turning off encryption here is a bad idea. I understand why we do that for localhost development, but if this ever runs on a real server then this is bad.
@vimayya please weigh in on how we should handle this connection string. Should we perhaps add a new command line parameter for encryption? Or change the command line parameter to require that the user provide the connection string?
There was a problem hiding this comment.
I would go for full connection string passed as parameter. It would be a breaking change but we could go that route considering this utility is not likely to have additional integrations.
No description provided.