[ADMINAPI-1117] - Adds /v2/resourceClaimActions and /v2/resourceClaimActionAuthStrategies endpoints.

[DavidJGapCR]

No description provided.

[github-actions]

Test Results

6 tests   6 ✅  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 7f40067.

♻️ This comment has been updated with latest results.

[DavidJGapCR]

Hi @jasonh-edfi . We have a question on these changes.
One of the new endpoints is resourceClaimActions. It is returning the information as shown on this screenshot.
The ticket says "Add /v2/resourceClaimActions as a select * from resourceClaimActions table"
So, as it is, it's just showing Ids.
So, the question is: Do we need to return ResourceClaims.ResourceName and Actions.ActionName as well?

[stephenfuqua]

I am curious: am I the only one who hates Automapper? I am not suggesting a change right now, because Automapper is how the application already does things. I just think it would be easier to debug and think about things if we wrote the following function inside the ResourceClaimAction class:

public ResourceClaimActionModel ToModel()
{
  return new
  {
    ResourceClaimName = this.ResourceClaim.ResourceClaimName,
    ActionName = this.Action.ActionName
  };
}

When things go wrong, it is very hard to debug if the object at runtime is flowing through AutoMapper. Plus, AutoMapper adds a little overhead to the mapping process. In other words, it will take longer to process that conversion than just using the plain code.

[stephenfuqua]

The class that needs to access this: does it need to modify the list contents? If not, then may I suggest returning as IReadOnlyList instead of returning as List?

[jagudelo-gap]

@jasonh-edfi @stephenfuqua
Would it be right for you if this branch contains some initial adminconsole implementation (including swagger definition)?

If not, we have to create a new branch from the tag v2.2.1 (not from the main branch) and issue a new PR.

[stephenfuqua]

@jasonh-edfi @stephenfuqua Would it be right for you if this branch contains some initial adminconsole implementation (including swagger definition)?

If not, we have to create a new branch from the tag v2.2.1 (not from the main branch) and issue a new PR.

Just saw this question from yesterday. As far as I'm concerned, everything for Admin Console should be going into main now, since Admin Console support is the primary reason for the next AdminApi-2 release.

[DavidJGapCR]

Can you undo the changes on this file?