[ADMINAPI-1119] - DRAFT - SPIKE: Cross-tenant Admin API Access #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidJGapCR
force-pushed
the
ADMINAPI-1119
branch
from
131fc4f to
bd22b71
Compare
DavidJGapCR
commented
Jan 20, 2025
| }; | ||
| }; | ||
|
|
||
| if (!string.IsNullOrEmpty(tenantIdentifier)) |
There was a problem hiding this comment.
On RegisterService, if a tenant as been sent on the request headers, add it to the application permissions.
DavidJGapCR
commented
Jan 20, 2025
| @@ -56,7 +60,19 @@ public async Task<ClaimsPrincipal> Handle(OpenIddictRequest request) | |||
|
|
|||
| var identity = new ClaimsIdentity(JwtBearerDefaults.AuthenticationScheme); | |||
| identity.AddClaim(OpenIddictConstants.Claims.Subject, request.ClientId!, OpenIddictConstants.Destinations.AccessToken); | |||
| identity.AddClaim(OpenIddictConstants.Claims.Name, displayName!, OpenIddictConstants.Destinations.AccessToken); | |||
| identity.AddClaim(OpenIddictConstants.Claims.Name, displayName!, OpenIddictConstants.Destinations.AccessToken); | |||
There was a problem hiding this comment.
Include the tenant as a claim to the access token.
DavidJGapCR
commented
Jan 20, 2025
| @@ -104,6 +105,18 @@ IWebHostEnvironment webHostEnvironment | |||
| { | |||
| opt.DefaultPolicy = new AuthorizationPolicyBuilder() | |||
| .RequireClaim(OpenIddictConstants.Claims.Scope, SecurityConstants.Scopes.AdminApiFullAccess) | |||
| .RequireAssertion(ctx => | |||
There was a problem hiding this comment.
Check if the tenant value on the header matches the one in the token.
Test Results6 tests 6 ✅ 0s ⏱️ Results for commit bd22b71. |
DavidJGapCR
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.