Added implementation of non cartesian grids. #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For discussion: @llorracc-git , @sbenthall . We discussed over skype the need to have nonregular grids. I started to implement two approaches:
I documented a bit what I did here: https://github.com/EconForge/dolark/blob/albop/new_grids/experiments/new_grids_discussion.ipynb
From these small experiments, I'm half convinced that warp functions are useless even though they are very simple to implement.
Note that most of the code is in
dolo_improvements.py
files. It will ultimately replace the decision rule code in dolo but for now, it is not used anywhere.