-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
16 improve print and summary #44
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub action failure seems to be due to a current update issue Likely will be resolved in a few days when brew recipes are updated. |
Current
|
That looks good. Doug
…On Sat, Nov 30, 2024 at 8:52 AM djsummer ***@***.***> wrote:
Current print.robustGARCH and summary.robustGARCH output:
> data("gspc")
> fit <- robGarch(gspc[1:604], methods="BM", fixed_pars = c(0.8, 3.0))
fit
> fit
Model: BM
Coefficients:
gamma alpha beta
7.30e-06 4.13e-02 8.12e-01
> summary(fit)
Model: BM, div = 0.8, k = 3
Data: gspc[1:604]
Observations: 604
Result:
Estimate Std.Error t-statistic p-value significance
gamma 0 0 0.022 0.982
alpha 0.041 5.711 0.007 0.994
beta 0.812 11.715 0.069 0.945
---
Signif. codes: 0 '***'' 0.001 '**'' 0.01 '*' 0.05 '.' 0.1 '' 1
Initial parameter estimates:
gamma alpha beta
0.64 0.00 0.40
Log-likelihood: 2.0533
Optimizer: Rsolnp
Time elapsed: 3.10632 secs
Convergence Message: 0
—
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP575Y7UYLI4GWDYUC47Z6D2DHUMVAVCNFSM6AAAAABSM2L7FSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZGAZTONRRGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
R. Douglas Martin
Professor Emeritus in Applied Mathematics and Statistics
University of Washington
|
The rest of the comment in the issue should be addressed, with the exception of:
|
On Sat, Nov 30, 2024 at 9:06 AM djsummer ***@***.***> wrote:
The rest of the comment in the issue should be addressed, with the
exception of:
1. #16 (comment)
<#16 (comment)>,
we'll need a custom algo to determine frequency, for the date we would need
the input to be enforced to xts.
Agreed, let's force the input to be an xts object.
1. The digits of the loglikelihood is fixed to 6 digits. Otherwise,
when we set the display to a smaller number it looks weird.
I guess that is fine as it gives enough additional precision relative to
typical rounding to 2 or 3
digits for tables in documents.
Doug
…
—
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP575Y5SSWJ2YF3UZ2NABMD2DHWBXAVCNFSM6AAAAABSM2L7FSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZGA3TKOBUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
R. Douglas Martin
Professor Emeritus in Applied Mathematics and Statistics
University of Washington
|
dan9401
force-pushed
the
16-improve-print-and-summary
branch
from
December 7, 2024 17:49
120bfa4
to
9eba516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@EchoRLiu @martinrd3D
This achieves mostly what
summary.lm
andprint.lm
are doing. Please take a look.One remaining item to achieve the following behavior of
summary.lm
, we need asummary.lm
class. I'm not sure if we want to do that.