Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1 #10515

Merged
merged 11 commits into from
Nov 21, 2023
Merged

1 #10515

merged 11 commits into from
Nov 21, 2023

Conversation

huji405
Copy link
Contributor

@huji405 huji405 commented Oct 19, 2023 •
edited
Loading

What does this PR do?

Add resource(s) | Remove resource(s) | Add info | Improve repo

For resources

Description

Added new tutorial to LUA section

Why is this valuable (or not)?

It teaches English speakers LUA

How do we know it's really free?

It's a Youtube video

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

eshellman
eshellman requested changes Oct 19, 2023
View reviewed changes
courses/free-courses-en.md Outdated
@@ -376,6 +376,7 @@

* [Cloud Computing and Development](https://uaceit.com/courses/cloud-computing-and-development) - Ashwin Kumar Ramaswamy (UAceIt) (email address *required*)
* [Cloud Computing Full Course In 11 Hours \| Cloud Computing Tutorial For Beginners](https://www.youtube.com/watch?v=2LaAJq1lB1Q) - Edureka!
* [Cloud Computing Tutorial for Beginners - Cloud Computing Explained - Cloud Computing](https://www.youtube.com/watch?v=RWgW-CgdIk0) - Simplilearn
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For youtube, we prefer "playlist" links and the name of the producer/creator. docs/CONTRIBUTING.md#platforms-and-access-notes

courses/free-courses-en.md Outdated
@@ -1155,6 +1156,7 @@

### Lua

* [Full Lua Programming Crash Course - Beginner to Advanced](https://www.youtube.com/watch?v=1srFmjt1Ib0) - Steve's teacher
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For youtube, we prefer "playlist" links and the name of the producer/creator. docs/CONTRIBUTING.md#platforms-and-access-notes

@eshellman eshellman added the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 19, 2023
@eshellman
Copy link
Collaborator

eshellman commented Oct 21, 2023 •
edited
Loading

Be sure to check the free-programming-books-lint output for linter errors. Alphabetical order and spacing are the most common problems.

@eshellman eshellman added the linter error Please, correct build errors found by linter! label Oct 21, 2023
@github-actions github-actions bot added the conflicts Conflict(s) need to be resolved label Oct 23, 2023
@github-actions
Copy link

Oh no 😟! Conflicts have been found.

Please 🙏, take a moment and address the merge conflicts of your pull request before we can evaluate it again.

Thanks in advance for your effort and patience ❤️!

@github-actions github-actions bot removed the conflicts Conflict(s) need to be resolved label Oct 23, 2023
@huji405
Copy link
Contributor Author

huji405 commented Oct 23, 2023

Please check my other branch named "3 changed" and leave a review. tysm

@github-actions github-actions bot added the conflicts Conflict(s) need to be resolved label Oct 24, 2023
@github-actions
Copy link

Oh no 😟! Conflicts have been found.

Please 🙏, take a moment and address the merge conflicts of your pull request before we can evaluate it again.

Thanks in advance for your effort and patience ❤️!

@Thenlie
Copy link
Contributor

Thenlie commented Nov 5, 2023

@huji405 I looked at your other PR's and they seem unrelated to this. So I think this is still valid? Feel free to close it out if not.

@github-actions github-actions bot removed conflicts Conflict(s) need to be resolved linter error Please, correct build errors found by linter! labels Nov 21, 2023
@eshellman eshellman merged commit b9d6a7c into EbookFoundation:main Nov 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshellman eshellman eshellman requested changes

Assignees
No one assigned
Labels
waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huji405 @eshellman @Thenlie