Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error due to missmatch type for duration value #1020

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

MaximilienR-easya
Copy link

@MaximilienR-easya MaximilienR-easya commented Aug 8, 2024

Fix #[Dolibarr#30593]

Fix error due to mismatch type for duration value. It should be an INT as it is everywhere in the code compared to INT value and passed as an INT to function or used in INT operation.
Keeping as a string can cause in example this error error evaluating code: Unsupported operand types: int + string
since PHP8.0.

…NT as it is everywhere in the code compared to int value and passed as an int to function
@MaximilienR-easya MaximilienR-easya added to repost Repost to dolibarr develop and removed to repost Repost to dolibarr develop labels Aug 8, 2024
@lvessiller-opendsi lvessiller-opendsi added the check merged Check merge on Dolibarr label Aug 9, 2024
@lvessiller-opendsi lvessiller-opendsi merged commit 9bf8dfa into 2024_rc Aug 9, 2024
@lvessiller-opendsi lvessiller-opendsi deleted the 2024_rc_Fix_duration_value_type branch August 9, 2024 08:45
@kkhelifa-opendsi kkhelifa-opendsi removed the check merged Check merge on Dolibarr label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants