More accurate battle animation shake #2136
Closed
+47
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPG_RT causes the shake effect to stay locked for 10 frames.
|
Is there a reason for the close? |
Ghabry
added
the
Awaiting Rebase
|
I'm closing this as it's badly out of date. We can revisit again later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPG_RT causes the shake effect to stay locked for 10 frames.
Fix: #2134
I still have some timing edge cases to work out.
Does anyone know exactly when in the main loop sequence the dynrpg
onFrame()callback happens?