Animate message boxes during transitions - Messages 7 of N #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reorganize update sequence * Add debug logging to debug frame timing issues * Simplify and streamline * Add hacks to match RPG_RT open/close timing and intpreter * Fix waits for printable and non-printable characters. It appears that RPG_RT animates the message open and close *after* the main loop. This causes a lot of complications for us, because much code depends on whether the message window is visible or closing. To workaround this difference we add close started and close finished flags and wrap them.
Allows for edge case when \> actually causes a wait.
If a half width character printed but didn't wait, it will always wait if proceeded by a full width char.
* Check for summon gold window before animating the message box * Handle gold window in repeated messages
Fixes incorrect timing in X\s[2]X\>\^
Fixes cases where inn message interrupts current text.
Fixes timing for multi-page level up messages
Emulates the RPG_RT behavior for EasyRPG#1706 Tests 17 & 18
mateofio
changed the title
mateofio
added
Messages
Has PR Dependencies
|
Killing this PR, if/when messages are revisited will take another look. All of this is recorded in github issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2026
WIP to emulate #1706 test cases 17, 18, and 27