Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Output::Error calls and invent new error "game error" #858

Open
Ghabry opened this issue Apr 7, 2016 · 1 comment
Open

Reduce Output::Error calls and invent new error "game error" #858

Ghabry opened this issue Apr 7, 2016 · 1 comment
Labels
UX For issues affecting the user experience, such annoyances, counter-intuitive or ugly design
Milestone
0.8.2

Comments

@Ghabry
Copy link
Member

Ghabry commented Apr 7, 2016

We still have Output::Error calls that are recoverable, like invalid BMP/XYZ/PNG.

And because we have a game browser now maybe we should differentiate between Output::Critical for stuff like "SDL init failed" and Output::Error should just clean up nicely and return to the GameBrowser (or shutdown if not on the stack).

The only unrecoverable game caused error I'm seeing is "Invalid Map", the rest could be handle gracefully.
@Ghabry Ghabry added the UX For issues affecting the user experience, such annoyances, counter-intuitive or ugly design label Apr 7, 2016
@Ghabry Ghabry added this to the 0.5.0 milestone Apr 7, 2016
@Ghabry Ghabry mentioned this issue Apr 7, 2016
Open
@fdelapena
Copy link
Contributor

Related: #432.

carstene1ns added a commit to carstene1ns/easyrpg-player that referenced this issue May 26, 2016
@carstene1ns
Do not crash on broken images. Related: EasyRPG#858,EasyRPG#432
db1c558 
This also degrades most image reader errors to warnings, because Player
does not need to close if one image is unreadable.
carstene1ns added a commit to carstene1ns/easyrpg-player that referenced this issue May 30, 2016
@carstene1ns
Do not crash on broken images. Related: EasyRPG#858,EasyRPG#432
329da6d 
This makes it also possible to degrades most image reader errors
to warnings, because Player can go on if one image is not useable.
carstene1ns added a commit to carstene1ns/easyrpg-player that referenced this issue Jul 14, 2016
@carstene1ns
Do not crash on broken images. Related: EasyRPG#858,EasyRPG#432
60aa87b 
This makes it also possible to degrades most image reader errors
to warnings, because Player can go on if one image is not useable.
carstene1ns added a commit to carstene1ns/easyrpg-player that referenced this issue Jul 24, 2016
@carstene1ns
Do not crash on broken images. Related: EasyRPG#858,EasyRPG#432
b34415c 
This makes it also possible to degrades most image reader errors
to warnings, because Player can go on if one image is not useable.
carstene1ns added a commit to carstene1ns/easyrpg-player that referenced this issue Aug 16, 2016
@carstene1ns
Do not crash on broken images. Related: EasyRPG#858,EasyRPG#432
00376f1 
This makes it also possible to degrades most image reader errors
to warnings, because Player can go on if one image is not useable.
Ghabry pushed a commit to Ghabry/easyrpg-player that referenced this issue Aug 23, 2016
@carstene1ns @Ghabry
Do not crash on broken images. Related: EasyRPG#858,EasyRPG#432
b31327b 
This makes it also possible to degrades most image reader errors
to warnings, because Player can go on if one image is not useable.
@Ghabry Ghabry modified the milestones: 0.6.1, 0.6.3 May 5, 2019
@Ghabry Ghabry mentioned this issue May 6, 2019
Merged
@carstene1ns carstene1ns mentioned this issue Dec 20, 2019
Merged
@Ghabry Ghabry modified the milestones: 0.6.3, 0.7.0 Apr 9, 2020
@Ghabry Ghabry modified the milestones: 0.7.1, 0.7.2 May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UX For issues affecting the user experience, such annoyances, counter-intuitive or ugly design
Milestone
0.8.2
Development

No branches or pull requests
2 participants
@fdelapena @Ghabry