Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System crash when an error occurs #16

Open
Rinnegatamante opened this issue Apr 7, 2016 · 2 comments
Open

System crash when an error occurs #16

Rinnegatamante opened this issue Apr 7, 2016 · 2 comments
Labels

Comments

@Rinnegatamante
Copy link
Owner

Whenever an error occurs that needs EasyRPG shutdown, it will cause a system crash with an hard-reboot.

@Ghabry
Copy link

Ghabry commented Apr 7, 2016

The Output::Error case calls DisplayUi.reset() followed by exit(1).
So when something must go, place it in the ctrui destructor.

Any other cleanup code will not run (which is not really an issue on real operating systems because they remove the garbage you left)

@Ghabry
Copy link

Ghabry commented Apr 7, 2016

But because EasyRPG has a game browser in the meanwhile this is actually a design error because it doesn't make sense anymore to terminate everything when a game error occurs. Should only shutdown the game... Creating an issue in the normal Player repo.

EasyRPG/Player#858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants