Convert expected for comparisons (#19)

* Convert expected values to float before comparison

This converts the expected values to a float before a `<` and `>`
comparison to prevent potential issues around the parsing of integer
values as strings when loading the YAML files. This is particularly of
issue with flat million numbers which are persisted in YAML as 6e+06
which is treated as a string when the YAML is parsed.

lib/toggles/feature.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
- 
+
 module Feature
   Error = Class.new(StandardError)
   Unknown = Class.new(Error)
@@ -75,8 +75,8 @@ def self.disabled?(*sym, **criteria)
   end
 }
 
-Feature.operations[:gt] = ->(entity, attr_name, expected) { entity.send(attr_name) > expected }
-Feature.operations[:lt] = ->(entity, attr_name, expected) { entity.send(attr_name) < expected }
+Feature.operations[:gt] = ->(entity, attr_name, expected) { entity.send(attr_name) > expected.to_f }
+Feature.operations[:lt] = ->(entity, attr_name, expected) { entity.send(attr_name) < expected.to_f }
 Feature.operations[:range] = lambda { |args|
   raise StandardError, 'Invalid range operation' if args.size != 2
 

lib/toggles/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Toggles
-  VERSION = '0.5.0'
+  VERSION = '0.6.0'
 end

spec/toggles/feature/operation_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
- 
+
 RSpec.describe 'operations' do
   context 'and' do
     subject { Feature.operations[:and] }
@@ -19,6 +19,10 @@
     specify do
       expect(subject.call(double(id: 50), :id, 40)).to eq true
       expect(subject.call(double(id: 50), :id, 60)).to eq false
+      expect(subject.call(double(id: 5_500_000), :id, "6e+06")).to eq false
+      expect(subject.call(double(id: 5_500_000), :id, 6e+06)).to eq false
+      expect(subject.call(double(id: 6_500_000), :id, "6e+06")).to eq true
+      expect(subject.call(double(id: 6_500_000), :id, 6e+06)).to eq true
     end
   end
 
@@ -38,6 +42,10 @@
     specify do
       expect(subject.call(double(id: 50), :id, 60)).to eq true
       expect(subject.call(double(id: 50), :id, 40)).to eq false
+      expect(subject.call(double(id: 5_500_000), :id, "6e+06")).to eq true
+      expect(subject.call(double(id: 5_500_000), :id, 6e+06)).to eq true
+      expect(subject.call(double(id: 6_500_000), :id, "6e+06")).to eq false
+      expect(subject.call(double(id: 6_500_000), :id, 6e+06)).to eq false
     end
   end