Update AbstractCrudController.php autocomplete to process fields #6807
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the autocomplete does not process fields, if you have a FieldConfigurator that modifies a custom option like AssociationField::OPTION_QUERY_BUILDER_CALLABLE it is not applied.
|
Check #6788 |
Similiar but not the same. The issue here is that the AbstractCrudController::autocomplete action does not apply any of the field configurators like the index does, so anything defined in a configurator will not be applied to the field. In my example the queybuilder, but it could apply to anything set on the filed in a configurator. |
|
Got it. You talk about setting this option in configurator, but not directly on field in |
get the entity from the origination page
fix phpstan formating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the autocomplete does not process fields, if you have a FieldConfigurator that modifies a custom option like AssociationField::OPTION_QUERY_BUILDER_CALLABLE it is not applied.