Update the logic of the menu item matcher #6383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is ready for the final review. This PR includes a BC break because an interface has been changed completely. I know this is unfortunate but, hopefully, this is an interface that it's rarely implemented by end-users. Now that we've fixed many edge-cases in the menu matching logic, it makes even less sense to implement your own logic. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6147 and fixes #6366
This PR changes the menu item matcher logic completely. Instead of using methods that look at each menu item individually to decide if it's selected or not ... now we have methods that take all menu items at once and find which one should be selected. This is needed to fix edge-cases.
I'll add more tests and comments/explanations in the code ... but this can be tested already in apps. I tested in my own apps and everything works as before. The new code feels as fast as before, but I also profiled it with Blackfire to double check it.