New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use form.children|length to set data-num-items in collection_row block #6160

Closed

pavol-tuka wants to merge 1 commit into EasyCorp:4.x from pavol-tuka:master

Contributor

pavol-tuka commented Feb 22, 2024

{% set row_attr = row_attr|merge({
    ...
    'data-allow-add': allow_add ? 'true' : 'false',
    'data-allow-delete': allow_delete ? 'true' : 'false',
    'data-num-items': form.children is empty ? 0 : max(form.children|keys),    <<< THIS LINE
    ...
}) %}

Consider form.children equals to:

Current implementation sets attribute data-num-items to 0, beacuse thats max key, but 1 is correct.


          Use form.children|length to set data-num-items in collection_row block

c9b7fc1

Contributor Author

pavol-tuka commented Feb 22, 2024

Related #4663, closing for now.

pavol-tuka closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet