Helper methods for Translatable objects in filters
#5822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this! I'm sorry it took us so long to merge it. Thanks Jakub. |
javiereguiluz
force-pushed
the
translatable-filters
branch
from
730470a
to
b4048ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR introduces support for translatable objects in a few places missed before - the filters:
setTranslatableChoicesmethod is added to theChoiceFilterandArrayFilter, working exactly like the same method inChoiceField,NullFilter::setChoiceLabelsmethod,TranslatableInterface, but weren't updated before.I have tested those changes on my daily project and they work as expected. I see that tests for filters are verifying their filtering capabilities and not passing configuration, so I found no place to add tests for those changes.