Add search for json properties #5819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
force-pushed
the
fix-search-for-json
branch
from
d77b4d7
to
62748b8
Compare
|
Thank you Julien. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋🏽
I realized that when searching in a CRUD, json properties were ignored despite being accounted for in the code (thanks to #5458 even if the code changed since, it's still essentially the same in that regard).
I've used this little "fix" in a project, and it worked fine.
It's honestly a copy/paste of what is done for text properties (since the DB column is really a
longtext), and it can definitely be improved, I simply do not know how 😄I figured opening this PR could at least open a discussion about the issue 🚀