Waterwitch i2c master #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evaan
reviewed
Feb 1, 2025
ros_workspace/src/waterwitch_backend/src/waterwitch_constants.cpp
Outdated
Show resolved
Hide resolved
To do: Bug fixes and testing.
abudgell
approved these changes
Feb 1, 2025
Allan i2c cpp
Evan-Vokey
reviewed
Feb 4, 2025
Zaid-Duraid
commented
Feb 13, 2025
| private: | ||
| rclcpp::Subscription<eer_interfaces::msg::WaterwitchControl>::SharedPtr control_values_subscriber; | ||
|
|
||
| void write_to_i2c(int device_address, uint8_t byte_1, uint8_t byte_2, uint8_t num_bytes) |
There was a problem hiding this comment.
I think we should put the num_bytes argument before byte1 and byte2
Change: num_bytes argument now before byte_1 and byte_2 in write_to_i2c method
Evan-Vokey
reviewed
Feb 13, 2025
…_i2c My changes based on comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds the following:
waterwitch_constants.cpp