Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Simplify teseting workflow
Browse files Browse the repository at this point in the history
Now that this is the only one actually using this,
the whole complexity here is totally unnecessary
Earlopain committed Jul 3, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent 55a7eeb commit ef9b6b2
Showing 3 changed files with 10 additions and 31 deletions.
20 changes: 0 additions & 20 deletions .github/prepare-docker-image/action.yml

This file was deleted.

20 changes: 9 additions & 11 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
@@ -12,10 +12,10 @@ permissions:
contents: read

jobs:
docker-build:
tests:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

@@ -24,21 +24,19 @@ jobs:
with:
cache-from: type=gha
cache-to: type=gha,mode=max
load: true
tags: reverser

tests:
runs-on: ubuntu-latest
needs: docker-build

steps:
- uses: actions/checkout@v4
- uses: ./.github/prepare-docker-image
# What a joke: https://stackoverflow.com/questions/74825294
- name: Set env variables
run: |
echo "REVERSER_DATA_PATH=${{ env.RUNNER_TEMP }}/${{ env.GITHUB_REPOSITORY_ID }}" >> $GITHUB_ENV
- name: Create DB
run: eval $DOCKER_RUN reverser bin/setup
run: docker compose run reverser bin/setup

- name: Run Tests
run: eval $DOCKER_RUN tests
run: docker compose run tests

rubocop:
runs-on: ubuntu-latest
1 change: 1 addition & 0 deletions test/controllers/config_controller_test.rb
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@

class ConfigControllerTest < ActionDispatch::IntegrationTest
test "index renders" do
puts ENV.to_h
get config_index_path
assert_response :success
end

0 comments on commit ef9b6b2

Please sign in to comment.