Make use of partial strict locals

Earlopain · Oct 5, 2023 · 42aa471 · 42aa471
1 parent b39420e
commit 42aa471
Show file tree

Hide file tree

Showing 14 changed files with 14 additions and 2 deletions.
diff --git a/app/views/application/_footer.html.erb b/app/views/application/_footer.html.erb
@@ -1,3 +1,4 @@
+<%# locals: () %>
 <footer>
   <%= Config.app_name %>
   – Rendered in <%= (Time.current.to_f - @start_time).round(3) %> seconds

diff --git a/app/views/application/_navbar.html.erb b/app/views/application/_navbar.html.erb
@@ -1,3 +1,4 @@
+<%# locals: () %>
 <header id="top">
   <nav id="nav">
     <%= link_to "", root_path, class: "logo" %>

diff --git a/app/views/artist_urls/_list.html.erb b/app/views/artist_urls/_list.html.erb
@@ -1,3 +1,4 @@
+<%# locals: (artist_urls:) -%>
 <div class="url-list">
   <% artist_urls.each do |artist_url| %>
     <%= render "artists/artist_link", artist_url: artist_url %>

diff --git a/app/views/artists/_artist_link.html.erb b/app/views/artists/_artist_link.html.erb
@@ -1,3 +1,4 @@
+<%# locals: (artist_url:) -%>
 <div class="artist-link">
   <%= site_icon artist_url %>
   <%= link_to artist_url.unescaped_url_identifier, artist_path(artist_url.artist, search: { artist_url_id: [artist_url.id] }), class: "site-icon-text" %>

diff --git a/app/views/artists/_secondary_links.html.erb b/app/views/artists/_secondary_links.html.erb
@@ -1,3 +1,4 @@
+<%# locals: () %>
 <%= subnav_link_to "Listing", artists_path %>
 <%= subnav_link_to "New", new_artist_path %>
 <% unless @artist&.id %>

diff --git a/app/views/config/_secondary_links.html.erb b/app/views/config/_secondary_links.html.erb
@@ -1 +1,2 @@
+<%# locals: () %>
 <%= subnav_link_to "Listing", config_index_path %>
diff --git a/app/views/log_events/_secondary_links.html.erb b/app/views/log_events/_secondary_links.html.erb
@@ -1 +1,2 @@
+<%# locals: () %>
 <%= subnav_link_to "Listing", log_events_path %>
diff --git a/app/views/submission_files/_e6_post_stats.html.erb b/app/views/submission_files/_e6_post_stats.html.erb
@@ -1,3 +1,4 @@
+<%# locals: (submission_file:) -%>
 <% submission_file.e6_posts.sort_by(&:similarity_score).reverse_each do |entry| %>
   <div>
   <%= link_to_external "##{entry.post_id}", "https://e621.net/posts/#{entry.post_id}", title: "Score: #{entry.score}" %>

diff --git a/app/views/submission_files/_list_with_search.html.erb b/app/views/submission_files/_list_with_search.html.erb
@@ -1,4 +1,4 @@
-<%# TODO: Figure out how remove the folder prefix %>
+<%# locals: (path:, artist_urls:, submission_files:) -%>
 <%= render "submission_files/search", path: path, artist_urls: artist_urls %>
 
 <% submission_files.each do |file| %>

diff --git a/app/views/submission_files/_multiselect.html.erb b/app/views/submission_files/_multiselect.html.erb
@@ -1,3 +1,4 @@
+<%# locals: () %>
 <%= toggleable("multiselect", "Enter select mode", "Leave select mode", visible_on_load: false) do %>
   <li><%= fake_link("Hide selected", id: "hide-selected") %> (<span class="selected-count">0</span>)</li>
   <li><%= fake_link("Backlog selected", id: "backlock-selected") %> (<span class="selected-count">0</span>)</li>

diff --git a/app/views/submission_files/_sample.html.erb b/app/views/submission_files/_sample.html.erb
@@ -1,4 +1,4 @@
-<% similarity ||= nil %>
+<%# locals: (submission_file:, similarity: nil) -%>
 <%= tag.div class: "submission-sample", data: { id: submission_file.id } do %>
   <% if submission_file.sample_generated? %>
     <div class="file-container">

diff --git a/app/views/submission_files/_search.html.erb b/app/views/submission_files/_search.html.erb
@@ -1,3 +1,4 @@
+<%# locals: (path:, artist_urls:) -%>
 <%= hideable_search(path) do |f| %>
   <%= f.input :artist_url_id, label: "URLs", collection: artist_urls, input_html: { multiple: true } if artist_urls.any? %>
   <%= f.input :upload_status, label: "Status", collection: [

diff --git a/app/views/submission_files/_secondary_links.html.erb b/app/views/submission_files/_secondary_links.html.erb
@@ -1,3 +1,4 @@
+<%# locals: () %>
 <%= subnav_link_to "Backlog", backlog_submission_files_path %>
 <%= subnav_link_to "Hidden", hidden_submission_files_path %>
 <% if instance_variable_defined?(:@search_params) %>

diff --git a/app/views/submission_files/_stats.html.erb b/app/views/submission_files/_stats.html.erb
@@ -1,3 +1,4 @@
+<%# locals: (submission_file:, similarity:) %>
 <% artist_submission = submission_file.artist_submission %>
 <% artist_url = submission_file.artist_url %>
 <div class="submission-stats">
Original file line number	Diff line number	Diff line change
		@@ -1 +1,2 @@
		<%# locals: () %>
		<%= subnav_link_to "Listing", config_index_path %>
Original file line number	Diff line number	Diff line change
		@@ -1 +1,2 @@
		<%# locals: () %>
		<%= subnav_link_to "Listing", log_events_path %>