Adds support for masters without hypervisors (#76)

* Fixes attempts to look up hypervisor on unmanaged masters

* Updates test data to cover hypervisor-less master nodes

* Inverts fail-fast-able condition

cmd/hope/utils/nodes.go

@@ -187,24 +187,32 @@ func GetAvailableMasters() ([]hope.Node, error) {
 	}
 
 	for _, node := range nodes {
-		if node.IsMaster() {
-			hv, err := GetHypervisor(node.Hypervisor)
-			if err != nil {
-				return nil, err
-			}
+		if !node.IsMaster() {
+			continue
+		}
+
+		if node.Hypervisor == "" {
+			retVal = append(retVal, node)
+			continue
+		}
 
-			hvNodes, err := hv.ListNodes()
+		// Need to get more node details from hypervisor
+		hv, err := GetHypervisor(node.Hypervisor)
+		if err != nil {
+			return nil, err
+		}
+
+		hvNodes, err := hv.ListNodes()
+		if err != nil {
+			return nil, err
+		}
+
+		if sliceutil.StringInSlice(node.Name, hvNodes) {
+			exNode, err := expandHypervisor(node)
 			if err != nil {
 				return nil, err
 			}
-
-			if sliceutil.StringInSlice(node.Name, hvNodes) {
-				exNode, err := expandHypervisor(node)
-				if err != nil {
-					return nil, err
-				}
-				retVal = append(retVal, exNode)
-			}
+			retVal = append(retVal, exNode)
 		}
 	}
 

cmd/hope/utils/nodes_test.go

@@ -59,8 +59,8 @@ var testNodes []hope.Node = []hope.Node{
 	{
 		Name:       "test-master-02",
 		Role:       hope.NodeRoleMaster.String(),
-		Hypervisor: "beast1",
 		User:       "packer",
+		Host:       "192.168.1.10",
 		Cpu:        2,
 		Memory:     2048,
 	},
@@ -278,8 +278,14 @@ func (s *NodesTestSuite) TestGetAvailableMasters() {
 
 	expectedOrig := testNodes[2:5]
 	expected := []hope.Node{}
+
 	for i, n := range expectedOrig {
-		n.Host = fmt.Sprintf("test-master-0%d", i+1)
+		if i == 1 {
+			n.Host = "192.168.1.10"
+		} else {
+			n.Host = fmt.Sprintf("test-master-0%d", i+1)
+		}
+
 		n.Hypervisor = ""
 		expected = append(expected, n)
 	}

hope.yaml

@@ -34,7 +34,7 @@ nodes:
     user: packer
   - name: test-master-02
     role: master
-    hypervisor: beast1
+    host: 192.168.1.10
     cpu: 2
     memory: 2048
     user: packer