fixes several bugs in Encrypt.zol #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcoolen
reviewed
May 15, 2025
src/boilerplate/orchestration/javascript/raw/boilerplate-generator.ts
Outdated
Show resolved
Hide resolved
|
LGTM! Perhaps consider splitting the changes into three separate commits: one for the variable ID fix, one for the internal function call fix, and one for the duplicate commitment error fix? |
jtcoolen
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following errors:
The state variable id is undefined in encrypted-data-listener.
An error due to the internal function call, because the function signature is incorrect.
Once the above error is fixed, commitments are generated twice from the encrypted-data-listener and the other orchestration files. The duplicate commitment error has been fixed.