Westlad/identify user #1413
Open
Westlad/identify user #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westlad
force-pushed
the
westlad/identify-user
branch
from
78e6c35 to
b0f09d2
Compare
There was a problem hiding this comment.
There is code from the PR in this one. It would be good to add some sort of documentation about the variable ANONYMOUS_USER.
|
I'll add documentation of the anonymous user. This code is a branch off the PR you've mentioned, but I wanted to get that one in first, before merging this, because the other PR is a refactor whereas this adds new functionality. |
israelboudoux
approved these changes
Apr 11, 2023
…o proxy the requests
Westlad
force-pushed
the
westlad/identify-user
branch
from
b8fce80 to
60bc907
Compare
israelboudoux
added
the
One more approval needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This code requires a User to prove to a Proposer that they hold a whitelisted Ethereum account. It is useful for cases where a Proposer wishes to show compliance with excluding non-whitelisted accounts. It is not strictly necessary because a non-whitelisted account cannot move funds into or out of Nightfall and therefore any transactions they may make within Nightfall are ultimately futile. However, this check provides extra assurance. It is entirely voluntary because there is no on-chain enforcement of the check. Proposers may disable the check, at their own risk, by setting the environment variable
ANONYMOUS_USER.What commands can I run to test the change?
This can be tested by running the normal test suite, whereby the check is enabled by default because ANONYMOUS_USER is not set.