fix: minor bugs

apps/proposer/src/routes/proposer.mjs

@@ -14,7 +14,7 @@ const router = express.Router();
 
 router.post('/offchain-transaction', async (req, res, next) => {
   const nf3 = req.app.get('nf3');
-  const { transaction } = req.body;
+  const { transaction, signature } = req.body;
   if (!transaction) {
     res.sendStatus(404);
     return;
@@ -34,7 +34,7 @@ router.post('/offchain-transaction', async (req, res, next) => {
   }
 
   try {
-    const res2 = await nf3.forwardOffchainTransaction(transaction);
+    const res2 = await nf3.forwardOffchainTransaction(transaction, signature);
     res.sendStatus(res2.status);
   } catch (error) {
     next(error);

cli/lib/nf3.mjs

@@ -1314,13 +1314,12 @@ class Nf3 {
     @param {object} transaction
     @returns {object} A promise that resolves to the API call status
    */
-  async forwardOffchainTransaction(transaction) {
+  async forwardOffchainTransaction(transaction, signature) {
     const res = await axios.post(
       `${this.optimistBaseUrl}/proposer/offchain-transaction`,
-      { transaction },
+      { transaction, signature },
       { timeout: 3600000 },
     );
-    console.log(`FORWARDING TO ${this.optimistBaseUrl}/proposer/offchain-transaction`);
     return res;
   }
 

nightfall-optimist/src/routes/proposer.mjs

@@ -411,8 +411,9 @@ router.post('/offchain-transaction', async (req, res) => {
   // the first thing we'll do is check that the sender is whitelisted (if required by our config)
   if (!process.env.ANONYMOUS_USER) {
     const address = web3.eth.accounts.recover(JSON.stringify(transaction), signature);
+    logger.debug(`Recovered address ${address}`);
     const x509Instance = await getContractInstance('X509');
-    const isWhitelisted = await x509Instance.x509Check(address);
+    const isWhitelisted = await x509Instance.methods.x509Check(address).call();
     if (!isWhitelisted) {
       logger.warn('Attempted transaction by a user who is not whitelisted');
       res.sendStatus(401);