Add max_item_size() to etl::ipool #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwellbelove
changed the base branch from
master
to
pull-request/#1001-Add-max_item_size()-to-etl-ipool
jwellbelove
merged commit f0ebf26
into
ETLCPP:pull-request/#1001-Add-max_item_size()-to-etl-ipool
63 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
etl::ipool is defined by an underlying buffer with Max_Size * Item_Size bytes.
While Max_Size is accessible via max_size() and capacity(), Item_Size is not accessible publicly.
However, it would be helpful in a scenario where items are allocated dynamically, e.g. dynamically sized messages, with different header and payload sizes.
This pull request provides max_item_size() for exactly this reason.