Added return to etl::optional emplace, fixed typo (#982)

ETLCPP · Dec 2, 2024 · b58ba95 · b58ba95
1 parent a88a48d
commit b58ba95
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/include/etl/optional.h b/include/etl/optional.h
@@ -484,14 +484,16 @@ namespace etl
       //*************************************************************************
       template <typename... TArgs>
       ETL_CONSTEXPR20_STL
-      void emplace(TArgs&& ... args)
+      T& emplace(TArgs&& ... args)
       {
         storage.construct(etl::forward<TArgs>(args)...);
+
+        return storage.u.value;
       }
 #else
       //*************************************************************************
       /// Emplaces a value.
-      /// 1 parameter.
+      /// 0 parameters.
       //*************************************************************************
       T& emplace()
       {
@@ -1048,14 +1050,16 @@ namespace etl
       //*************************************************************************
       template <typename... TArgs>
       ETL_CONSTEXPR14
-      void emplace(TArgs&& ... args)
+      T& emplace(TArgs&& ... args)
       {
         storage.construct(etl::forward<TArgs>(args)...);
+
+        return storage.value;
       }
 #else
       //*************************************************************************
       /// Emplaces a value.
-      /// 1 parameter.
+      /// 0 parameters.
       //*************************************************************************
       T& emplace()
       {

diff --git a/test/test_optional.cpp b/test/test_optional.cpp
@@ -157,6 +157,16 @@ namespace
       CHECK_EQUAL(0, int(result.value()));
     }
 
+    //*************************************************************************
+    TEST(test_emplace_return)
+    {
+      etl::optional<DataM> data;
+
+      DataM* datam = &data.emplace(1U);
+      CHECK_EQUAL(datam, &data.value());
+      CHECK(datam != nullptr);
+    }
+
     //*************************************************************************
     TEST(test_moveable)
     {